Cluster reboot #66
Open
Cluster reboot #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @yprokule |
mcornea
reviewed
Feb 5, 2024
| @@ -0,0 +1,194 @@ | |||
| package ungraceful_system_test | |||
There was a problem hiding this comment.
Can we have this as a function under tests/internal/reboot/reboot.go so that it could be used in other test suites instead of having a separate reboot suite?
There was a problem hiding this comment.
thanks @mcornea, updated:
- added dedicated function
- existing reboot suite updated to use it
There was a problem hiding this comment.
@yprokule so you want to have a separate test suite only for the reboot tests? Imo these should be part of a higher level test suite alongside other tests, focused on a specific use case, e.g. a core suite assuming these tests are going to run against a telco core environment.
yprokule
force-pushed
the
cluster-reboot
branch
from
420fa7c
to
86d64e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that verifies ungraceful node(s) reboot